Subject: Re: PF for netbsd
To: None <itojun@iijlab.net>
From: Darren Reed <avalon@caligula.anu.edu.au>
List: tech-net
Date: 07/03/2003 01:12:07
In some mail from itojun@iijlab.net, sie said:
>
> >Itojun, if you're serious about making this cross platform and
> >not require PF then code like this:
> >+#if NPF > 0
> >+ tagvalue = pf_tagname2tag(tag->sadb_x_tag_name);
> >+ /* tag refcnt++ */
> >+ newsp = key_getspbytag(tagvalue, xpl0->sadb_x_policy_dir);
> >+#else
> >+ panic("PF");
> >+#endif
> >has to change before it goes in NetBSD.
>
> see the code above there. the "panic" part will never be visited.
And why won't it if I have a kernel that doesn't have PF but instead
uses another 3rd party classifier ?
Or if the "panic" part will never be visited, why is it there ?
One way or another, it seems, to me, to need fixing.
Darren