Subject: Re: goto bad in ip_output()
To: None <enami@sm.sony.co.jp>
From: Jun-ichiro itojun Hagino <itojun@itojun.org>
List: tech-net
Date: 10/14/2003 12:28:56
> enami tsugutomo <enami@but-b.or.jp> writes:
>
> > Two `goto bad' in ip_output() near the end is doubtful.
> >
> > `if (error) goto bad' after the ip_fragment() just leads mbuf leak if
> > it returns ENOBUFS. the for() loop after ip_fragment() can also
> > handle error case well. And the leak actually hangs NFS.
> >
> > The `goto bad' in the if-clasue just above ip_fragment() call is
> > doubtful. Why cleanups aren't necessary?
>
> The latter was ok, I missed the `goto done;'
will fix it.
itojun