--z6Eq5LdranGa6ru8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 28, 2004 at 08:04:29AM +0900, YAMAMOTO Takashi wrote:
> hi,
>=20
> does anyone object if i bump sb_timeo to int?
> with short sb_timeo and hz=3D1024, maximum SO_SND/RCVTIMEO is
> about 31 seconds, which seems too short to me.

Sounds fine, but I'd wait to see what say Jason has to say. I don't
_think_ this will slow down processing much but I don't know.

My one comment is:

> Index: sys/socketvar.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/socketvar.h	(revision 774)
> +++ sys/socketvar.h	(revision 775)
> @@ -61,8 +61,8 @@ struct sockbuf {
>  	struct mbuf *sb_mbtail;		/* the last mbuf in the chain */
>  	struct mbuf *sb_lastrecord;	/* first mbuf of last record in
>  					   socket buffer */
> +	int	sb_timeo;		/* timeout for read/write */
>  	short	sb_flags;		/* flags, see below */
> -	short	sb_timeo;		/* timeout for read/write */
>  };
> =20
>  #ifndef SB_MAX

Since sb_timeo and sb_flags packed nicely before but don't now, how about=
=20
turning flags into an int too?

Take care,

Bill

--z6Eq5LdranGa6ru8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFA4GRtWz+3JHUci9cRAgkcAJ9DEDFRoo36h9nI6N0Ig5TncDMMaACfROH2
fteCUaJSpKxp3DhO7IbHrUk=
=K79a
-----END PGP SIGNATURE-----

--z6Eq5LdranGa6ru8--