Subject: Re: CVS commit: src/usr.bin/netstat
To: Luke Mewburn <lukem@NetBSD.org>
From: Simon Burge <simonb@wasabisystems.com>
List: tech-net
Date: 09/07/2004 12:04:16
[ moved to tech-net ]

Luke Mewburn wrote:

> On Mon, Sep 06, 2004 at 02:51:32PM +0000, Martin Husemann wrote:
>   |
>   | Module Name:	src
>   | Committed By:	martin
>   | Date:		Mon Sep  6 14:51:32 UTC 2004
>   |
>   | Modified Files:
>   | 	src/usr.bin/netstat: inet.c mroute.c
>   |
>   | Log Message:
>   | Make it compile on ports where u_quad_t is not printf-format-compatible
>   | with unsigned long long.
> 
> We really should be using "(unsigned) long long" instead of "(u_)quad_t"
> in code going forward, since the former is part of C99 and the latter
> is an extension that was added because the former wasn't standardized.

It seems that all (or at least most) of the 'struct foostat' in
sys/netinet use u_quad_t for counters.  Maybe they should all be
switched to use uint64_t?

Simon.
--
Simon Burge                            <simonb@wasabisystems.com>
NetBSD Support and Service:         http://www.wasabisystems.com/