Subject: Re: ip_input() bad csum count not incremented on sw csum
To: None <christos@zoulas.com>
From: Sean Boudreau <seanb@qnx.com>
List: tech-net
Date: 09/29/2004 16:43:07
Done (kern/27081, kern/27082). I've no problem with
send-pr but my experience has been that it's kind of
a black hole recently.
bin/21459
kern/19895
kern/21902
kern/22849
Regards,
-seanb
On Wed, Sep 29, 2004 at 04:03:22PM -0400, christos@zoulas.com wrote:
> In article <20040929193932.GC2924564@qnx.com>,
> Sean Boudreau <seanb@qnx.com> wrote:
>
> You should really be send-pr'ing these so that they don't get lost.
>
> thanks,
>
> christos
>
> >Index: netinet/ip_input.c
> >===================================================================
> >RCS file: /cvsroot/src/sys/netinet/ip_input.c,v
> >retrieving revision 1.203
> >diff -c -r1.203 ip_input.c
> >*** netinet/ip_input.c 25 May 2004 04:34:00 -0000 1.203
> >--- netinet/ip_input.c 29 Sep 2004 19:36:55 -0000
> >***************
> >*** 575,581 ****
> > /* Must compute it ourselves. */
> > INET_CSUM_COUNTER_INCR(&ip_swcsum);
> > if (in_cksum(m, hlen) != 0)
> >! goto bad;
> > break;
> > }
> >
> >--- 575,581 ----
> > /* Must compute it ourselves. */
> > INET_CSUM_COUNTER_INCR(&ip_swcsum);
> > if (in_cksum(m, hlen) != 0)
> >! goto badcsum;
> > break;
> > }
> >
>