Subject: Re: ipsec4_splithdr invariant not right
To: Greg Troxel <gdt@ir.bbn.com>
From: Christos Zoulas <christos@zoulas.com>
List: tech-net
Date: 04/20/2007 10:53:41
On Apr 20, 9:12am, gdt@ir.bbn.com (Greg Troxel) wrote:
-- Subject: Re: ipsec4_splithdr invariant not right
| christos@astron.com (Christos Zoulas) writes:
|
| > In article <rmi8xcoe33s.fsf@fnord.ir.bbn.com>,
| > Greg Troxel <gdt@ir.bbn.com> wrote:
| >
| >>ipsec4_splithdr: m->m_len 0 m_length 176 < 20
| >>ipsec4_splithdr: m->m_len 0 m_length 176 < 20
| >>ipsec4_splithdr: m->m_len 0 m_length 176 < 20
| >>
| >>I don't see why it's reasonable for ipsec4_splithdr to assume that
| >>struct ip fits in the first mbuf.
| >
| > Is the second if statement even possible to fire?
|
| If you mean rechecking the results of pullup after we confirmed we
| didn't get null back, then no, I don't think it's possible. Were I to
| commit this I'd drop that, and drop the printfs.
I'd say do that. Although I don't understand why I never see it on my
x86 box.
christos