Subject: Re: IPSEC_NAT_T for FAST_IPSEC
To: None <degroote@NetBSD.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: tech-net
Date: 06/20/2007 18:51:23
degroote@NetBSD.org wrote:

> Can you review the following patch

Just only cosmetic part:
- ANSI style function declarations are better
- no need __P() at least for new functions
- memset() rather than bzero()
- IPSEC_NAT_T option should be defflag'ed in files.netipsec?
- I wonder if some pointer casts might cause problems
  on gcc -fstrict-aliasing

---
Izumi Tsutsui