tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Review of pfs(8)



On 06/Apr - 17:47, Christos Zoulas wrote:
> In article <20100406173323.GA29417%lavache.laas.fr@localhost>,
> Arnaud Degroote  <arnaud.degroote%laas.fr@localhost> wrote:
> >On 06/Apr - 14:46, Christos Zoulas wrote:
> >> >Hi,
> >> >
> >> >I would like to integrate pfs(8) into the main tree. pfs is a tool 
> >> >similar as
> >> >ipfs(8) but for the pf(4) filtering solution, aka it lets the 
> >> >administrator
> >> >dumps the current internal state table of pf, reboot for maintenance,
> >and loads
> >> >the saved table into pf, in a tranparent way for users. 
> >> >
> >> >I attach the current version of the code in attachment. If there are
> >no comment,
> >> >I will push it to main tree next week.
> >> 
> >> - Add copyrights.
> >> - The switch indentation is not KNF.
> >
> >I have updated the patch on
> >http://ftp.netbsd.org/pub/NetBSD/misc/degroote/pfs.diff fixing the two issues
> >you noted and adding RCSID stuff.
> 
> great, buf[100] can be overrun, right?

You are right, I add some protection against ill-formed sequence (buf must
contain string representation of int32_t). 

-- 
Arnaud Degroote
PhD Student 
RIA LAAS / CNRS

Attachment: signature.asc
Description: Digital signature



Home | Main Index | Thread Index | Old Index