Re: locking errors in IPF in netbsd-6

[Chuck Silvers <chuq%chuq.com@localhost>]

On Sun, Mar 10, 2013 at 07:01:38PM +0000, David Laight wrote:
> On Sun, Mar 10, 2013 at 11:28:27AM -0700, Chuck Silvers wrote:
> > -/*                                                                         
> > */
> > -/* NOTE: It is by design that this function returns holding a read lock on 
> > */
> > -/*       ipf_tokens.  Callers must make sure they release it!              
> > */
> >  /* ----------------------------------------------------------------------- 
> > */
> 
> Does that comment really mean that the non-NULL return value might
> become invalid as soon as the lock is released?

looking at what the callers do, it appears that this comment is no longer 
correct.
with my patch, I think the code now matches the locking logic in the newer 
version
of IPF in -current, and that comment was removed from the corresponding function
there, thus my patch removes it as well.

-Chuck