Re: RFC: ALTQ caller refactor

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Feb 23, 2016 at 01:52:40PM +0900, Kengo NAKAHARA wrote:
> Hi,
> 
> I want to uniform IFQ_ENQUEUE arguments whether ALTQ is defined or not.
> # And I also want to eliminate ALTQ_DECL and ALTQ_COMMA macros...
>  So, I make struct altq_pktattr from IFQ_CLASSIFY and IFQ_ENQUEUE argument
> to m_tag. Here is the patch.
>     http://netbsd.org/~knakahara/altq-caller-refactor/altq-caller-refactor.patch
> 
> In above patch, I fix performance issue by the following two ways.
>     - make ALTQ's m_tag pool cache
>     - inline altq_*_pattr functions
> Without these two fixes, the enabled ALTQ throughput degraded about 10%.
> However, with these two fixes, the throughput is almost the same
> performance.

Is there a good reason to keep the complexity of the pattr attribute
around? From working on the ALTQ code a few years ago I remember that it
is only used by some of the more experimental mechanisms and not used by
the few queueing disciplines people normally care about. It might be
easier to just get rid of it.

Joerg