Re: RFC: vlan(4) use pkthdr instead of mtag

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wed, Sep 20, 2017 at 02:05:38PM +0900, Shoichi YAMAGUCHI wrote:
> > cxgb_sge.c's t3_encap should not predicate the VLAN support.
> Sorry, I don't understand you. Does this remark means the functions
> related to VLAN like vlan_has_tag should use with "#if NVLAN > 0" ?

No, I mean it just shouldn't use __predict_false for the branch. That's
a stupid assumption to make. Does that make it clearer?

> Thank you the comment. I took a same mistake in VLAN_TAG_VALUE
> and fixed them.

In VLAN_TAG_VALUE it doesn't matter as it stores the entry in the field
reusing the remaining bits. In this case, the other bits of the vlan
field where used for other purpses.

Joerg