Re: Porting umb(4) from OpenBSD

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 04/05/2018 à 03:27, Pierre Pronchery a écrit :
> 			Hey tech-net@, (Maxime)
>
> On 03/05/2018 09:58, Maxime Villard wrote:
> > Le 03/05/2018 à 04:46, Pierre Pronchery a écrit :
> > > You can obtain the fix(es) and follow my changes as I go here:
> > > https://git.edgebsd.org/gitweb/?p=src.git;a=shortlog;h=refs/heads/khorben/umb
> >
> >      int         umb_match(device_t, cfdata_t, void *);
> >      [etc]
> > please make all of that static, global symbols are bad
>
> Done.

I think it would have been better to use "static" instead of "Static", aliases
are bad too.

>  [...]
> >      sc->sc_resp_buf = kmem_alloc(sc->sc_ctrl_len, M_NOWAIT);
> >
> > that's the wrong flag
>
> Mmh it is this way in the original driver. Is there a specific
> requirement on our side there?

I meant to say, M_NOWAIT -> KM_NOSLEEP. And the other similar issues, like

	c = kmem_alloc(sizeof(*c), M_WAIT|M_ZERO);

which should be

	c = kmem_zalloc(sizeof(*c), KM_SLEEP);

etc.

Thanks,
Maxime