tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: removal of bpf_tap() (not bpf_mtap)




> On Jun 22, 2018, at 2:50 AM, Masanobu SAITOH <msaitoh%execsw.org@localhost> wrote:
> 
> Hi.
> 
> The following two changes removed bpf_tap() which uses linear data
> instead of mbuf:
> 
> 	http://mail-index.netbsd.org/source-changes/2018/06/22/msg096214.html
> 	http://mail-index.netbsd.org/source-changes/2018/06/22/msg096215.html
> 
> Only above two drivers used bpf_tap(). There is no any driver
> which use it now. Is it OK to remove from bpf.[ch]?

Seems fine to me.  It's trivial to wrap a linear buffer in an mbuf if needed.

> 
> -- 
> -----------------------------------------------
>                SAITOH Masanobu (msaitoh%execsw.org@localhost
>                                 msaitoh%netbsd.org@localhost)

-- thorpej



Home | Main Index | Thread Index | Old Index