Re: bnx(4) lockups?

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/03/28 12:56, Masanobu SAITOH wrote:
> > > Back to the first mail:
> > >
> > > > If connected to the Internet and traffic is flowing, it will lock solid after a while
> > >
> > > Does the machine recover from the hard hang after stopping the traffic?
> > > e.g. removing cable.
> >
> >   New patch:
> >
> >      http://www.netbsd.org/~msaitoh/bnx-n7-20190326-0.dif
> >      http://www.netbsd.org/~msaitoh/bnx-n8-20190326-0.dif
> >      http://www.netbsd.org/~msaitoh/bnx-cur-20190326-0.dif
> >
> > This diff might improve stability on heavy interrupt.
> > It seems that bnx(4) also doesn't support the flow control.
> > I'll add it in a few days.
>
> New patches:
>
>      http://www.netbsd.org/~msaitoh/bnx-n7-20190328-0.dif
>      http://www.netbsd.org/~msaitoh/bnx-n8-20190328-0.dif
>
>      And copy the latest bnxfw.h (rev. 1.5)
>      http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/microcode/bnx/bnxfw.h

Updated patches:

	http://www.netbsd.org/~msaitoh/bnx-n7-20190329-0.dif
	http://www.netbsd.org/~msaitoh/bnx-n8-20190329-0.dif
	And don't forget to copy the latest bnxfw.h (rev. 1.5)

I can't reproduce the hangup problem...

> > If connected to the Internet and traffic is flowing, it will lock solid after a while
>
> Does the machine recover from the hard hang after stopping the traffic?
> e.g. removing cable. 

If the machine doesn't recover from the hang even if no traffic, I think
the above diff won't fix the problem (flow control might decrease the
possibility of the hang).

 The descriptor ring and/or DMA map stuff might have bugs. I'm not
familiar with the code in NetBSD's if_bnx.c, so I can't modify them.
Sorry. (If I could reproduce the problem, I could ...)
Does anyone take a look? NetBSD's if_bnx.c has NetBSD specific modification
in the buffer management. It would be worth to try replace it with OpenBSD's
or FreeBSD's.

 Regards.

--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)