Re: locking against myself, mbuf was already freed

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Mon, Sep 30, 2019 at 04:49:53PM +0200, Edgar Fuß wrote:
> > Anyway, I guess the attached patch could fix it.
> Yes, it does. The machine is running Icinga 2 on a DIAGNOSTOC+DEBUG+LOCKDEBUG 
> kernel for nearly an hour now while before, it would panic in seconds.
> 
> > Maybe try to
> > #define FASTROUTE_RECURSION
> > at the top of fil.c ?
> I also included this (if defined(__NetBSD__)).
> 
> > It looks like this is needed
> Yes, thanks!
> Does the #define really belong into the file or should it rather be some 
> -D in a Makefile?

FASTROUTE_RECURSION is only tested in fil.c so it can be #defined here

> 
> Thanks a lot for the two patches!
> Could you commit this and request pull-ups?

Just commited, will request pullups later

> And I'm asking myself again whether I'm the only remaining consumer of IPFilter.

No, I'm using it too. But this kind of bug heavyly depends on the rules
(in this case, the use of route-to or dup-to I guess)

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--