Re: [netbsd-9] ipgphy breaks without ukphy

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/12/10 22:43, Hauke Fath wrote:
> All,
> 
> since this change to sys/dev/mii/ipgphy.c on netbsd-9
> 
> 1.3          (msaitoh  14-Nov-19):      /* For IP1000A, use generic way */
> 1.3          (msaitoh  14-Nov-19):      if (sc->mii_mpd_model == MII_MODEL_xxICPLUS_IP1000A) {
> 1.3          (msaitoh  14-Nov-19):              ukphy_status(sc);
> 1.3          (msaitoh  14-Nov-19):              return;
> 1.3          (msaitoh  14-Nov-19):      }
> 
> a kernel configured with ipgphy, but no ukphy errors out with
> 
> [...]
> #      link  HP2170P/netbsd
> /local/netbsd-builds/9/amd64/tools/bin/x86_64--netbsd-ld -Map netbsd.map --cref -T netbsd.ldscript -Ttext 0xffffffff80200000 -e start -z max-page-size=0x200000 -X -o netbsd ${SYSTEM_OBJ:[@]:Nswapnetbsd.o} ${EXTRA_OBJ} vers.o swapnetbsd.o
> /local/netbsd-builds/9/amd64/tools/bin/x86_64--netbsd-ld: ipgphy.o: in function `ipgphy_status':
> /local/source/netbsd-9/src/sys/dev/mii/ipgphy.c:251: undefined reference to `ukphy_status'
> *** [netbsd] Error code 1
> 
> Is this known, intended, could the dependency be made explicit?

 Fixed by files.mii rev. 1.54 (and will be pulled up to netbsd-9).

Thanks!

> Cheerio,
> hauke
> 


-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)