tech-net archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: IFF_OACTIVE -- is it still relevant?
On Fri, Jan 17, 2020 at 02:19:24PM -0800, Jason Thorpe wrote:
> Hey folks --
>
> IFF_OACTIVE is problematic for NET_MPSAFE because it lives in ifnet::if_flags, but needs to be fiddled with when ifnet::if_ioctl_lock is not held.
>
> In some ways, I question the utility of IFF_OACTIVE .. at best, it avoids calling (*if_start)() if there are no transmit slots available... but that situation is something that (*if_start)() routines need to handle anyway.
Right, it's not really useful. In multiple ring/queue/processor
situations, you end up maintaining multiple output-active indications,
each one independent from IFF_OACTIVE.
Dave
--
David Young
dyoung%pobox.com@localhost Urbana, IL (217) 721-9981
Home |
Main Index |
Thread Index |
Old Index