Re: Can WM_EVENT_COUNTERS be enabled default?

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

On 2021/01/27 13:36, Jason Thorpe wrote:
> > On Jan 26, 2021, at 7:51 PM, Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost> wrote:
> >
> > Hi,
> >
> > Thank you for your comments.
> >
> > On 2021/01/27 12:14, Jason Thorpe wrote:
> > > > On Jan 26, 2021, at 6:21 PM, Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost> wrote:
> > > >
> > > > Someone may worry about any other effects, I will add new kernel option
> > > > WM_DISABLE_EVENT_COUNTERS, please use it.
> > > No strong objection from me, but can we enable it by default only on systems with 64-bit atomics?
> >
> > I see.  Hmm, I will enable WM_EVENT_COUNTERS for amd64 and aarch64
> > instead of adding WM_DISABLE_EVENT_COUNTERS.  And then, I will also
> > enable for other 64 bit architectures.
>
> I think you can safely enable it by default for all _LP64.  Are the stats incremented with atomics?

Ah, the stats are just incremented (not atomic ops) because they are
incremented by one CPU or protected by locks.  I will enable it as you
say.


Thanks,

--
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Product Development Department,
Product Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>