tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Memory leak in sys/external/bsd/ipf/netinet/ip_fil_netbsd.c:ipf_send_ip()?



I'm not sure if that code can be actually reached, but I'm under the impression 
that there's a memory leak in external/bsd/ipf/netinet/ip_fil_netbsd.c in 
ipf_send_ip():

static int
ipf_send_ip(fr_info_t *fin, mb_t *m)
{
[...]
	switch (fin->fin_v)
	{
#ifdef INET
	case 4 :
[...]
#endif
#ifdef USE_INET6
	case 6 :
[...]
#endif
	default :
		return EINVAL;
	}
[...]
	return ipf_fastroute(m, &m, &fnew, NULL);
}

In the normal case, m is eventually freed by ipf_fastroute(). But in the 
default: case, it looks like there's a
	FREE_MB_T(m);
missing.


Home | Main Index | Thread Index | Old Index