Subject: Re: Bad definition of USE_LIBTOOL in bsd.pkg.mk
To: Todd Vierling <tv@wasabisystems.com>
From: Frederick Bruckman <fb@enteract.com>
List: tech-pkg
Date: 01/26/2001 13:24:47
On Fri, 26 Jan 2001, Todd Vierling wrote:

> .if defined(USE_LIBTOOL)
> LIBTOOL=                ${LOCALBASE}/bin/libtool
> # XXX: actually, here we would need something like
> # BUILD_DEPENDS+=libtool>=1.3.5nb9:../../devel/libtool
> .if make(install-run-depends) || make(fetch-list-recursive) ||
> make(show-depends-dirs)
> DEPENDS+=               libtool>=1.3.5nb9:../../devel/libtool
> .endif
> .endif
>
> This is completely unacceptable.  It never should have been changed from a
> BUILD_DEPENDS in the first place -- there is no reason that packages should
> depend on libtool at runtime.

I don't do it, but notice that the ".if make(...)"'s prevent the
dependency from being registered at install or package time, so it's
not so bad.

--

Frederick