-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sure, that works for me -- the variable names are 2-AMish, and I agree
can be clearer...

On Fri, 26 Jan 2001, Hubert Feyrer wrote:

>On Fri, 26 Jan 2001, Jim Wise wrote:
>> Note that this just uses the -L / @src support already in pkg_create
>> (presumably implemented to support this sort of thing).
>
>Assuming this was tested with more than 1-2 simple pkgs, I only have one
>small nit: can we please rename the variables different:
>
>Rename BINPKG_ARGS => PKG_ARGS_COMMON

s/BINPKG_ARGS/BASE_PKG_ARGS/, right?

>Then:
>
>Instead of setting PKG_ARGS:
>PKG_ARGS_INSTALL=       ${BASE_PKG_COMMON} \
>			-p ${PREFIX} ${BASE_PKG_COMMON} -O
>
>Instead of setting BINPKG_ARGS:
>PKG_ARGS_PKGING=        ${BASE_PKG_COMMON} \
>			-p ${PREFIX:C/^${DESTDIR}//} -L ${PREFIX}
>
>Then in the first call to PKG_CREATE (line ~1565), use:
>        if ${PKG_CREATE} ${PKG_ARGS_PKGING} ${PKGFILE}; then
>
>In the second call to PKG_CREATE (line ~3197), use:
>        ${PKG_CREATE} ${PKG_ARGS_INSTALL} ${PKGFILE}	\
>		>${PKG_DBDIR}/${PKGNAME}/+CONTENTS;	\
>
>Might make things a bit clearer...

- -- 
				Jim Wise
				jwise@draga.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (NetBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE6ce0p2JhG4/qi8rQRAg2xAKC0E2wWE4iXzpyPam9nNL9dA+9xeACgrlv4
u1l14bJa47U77xWw4ZQcqyc=
=Xerf
-----END PGP SIGNATURE-----