Subject: Re: muhah
To: Bill Studenmund <wrstuden@zembu.com>
From: Alistair Crooks <agc@pkgsrc.org>
List: tech-pkg
Date: 03/26/2001 16:36:18
On Sat, Mar 24, 2001 at 05:09:48PM -0800, Bill Studenmund wrote:
> On Fri, 23 Mar 2001, Trevor Johnson wrote:
> 
> > You misunderstand.  What I requested is output from "digest sha1 foo" in
> > the format that "openssl dgst -sha1 foo" has, and likewise for "digest
> > rmd160 foo" to have the same format as "openssl dgst -rmd160".  That way,
> > if it ever becomes desirable to use OpenSSL for hashing--for instance, in
> > a future world where pre-1999 versions of NetBSD needn't to be fully
> > supported--such massaging will not be necessary.  I've appended a trivial
> > patch which does this.  For the SHA-1 and RIPEMD-160 hashes, the slightly
> > different output is unnecessary.  MD5 hashes have already been calculated,
> > so I don't propose changing them.
> 
> Looks fine to me. 

It doesn't look fine to me, since this is incompatible with the *BSD md5(1)
output format.

Regards,
Alistair

 
> Take care,
> 
> Bill
> 
> > -- 
> > Trevor Johnson
> > http://jpj.net/~trevor/gpgkey.txt
> > 
> > --- digest.c.orig	Fri Mar  9 13:24:49 2001
> > +++ digest.c	Fri Mar 23 08:04:20 2001
> > @@ -95,7 +95,7 @@
> >  		if (SHA1File(fn, digest) == NULL) {
> >  			return 0;
> >  		}
> > -		(void) printf("SHA1 (%s) = %s\n", fn, digest);
> > +		(void) printf("SHA1(%s)= %s\n", fn, digest);
> >  	}
> >  	return 1;
> >  }
> > @@ -119,7 +119,7 @@
> >  		if (RMD160File(fn, digest) == NULL) {
> >  			return 0;
> >  		}
> > -		(void) printf("RMD160 (%s) = %s\n", fn, digest);
> > +		(void) printf("RIPEMD160(%s)= %s\n", fn, digest);
> >  	}
> >  	return 1;
> >  }
> > 
> > 
>