Subject: Re: mk/compiler.mk
To: John R. Shannon <john@johnrshannon.com>
From: grant beattie <grant@NetBSD.org>
List: tech-pkg
Date: 12/05/2003 01:44:47
On Thu, Dec 04, 2003 at 06:46:19AM -0700, John R. Shannon wrote:
> I'm noticing several things in compiler.mk that appear wrong:
>
> 1. lines 133-134 - Should the order be reversed reversed?
>
> _GCC_ARCHDIR= ${_GCC_PREFIX}${_GCC_ARCHSUBDIR}
> _GCC_PREFIX= ${LOCALBASE}/${_GCC_SUBPREFIX}
>
> 2. lines 176-177, same thing
these are fine, as NetBSD make evaluates variables when they are used,
rather than when they are assigned (unless := is used).
> 3. lines 49,233 ${CC} -V
>
> cc -V
> cc: `-V' option must have argument
>
> with gcc 3.3.2
you shouldn't hit this, as _CC_IS_GCC should be defined either by the
test around line 86, or when USE_GCC2/USE_GCC3 is defined. do you have
a test case?
> 4. If I specify USE_GCC3 in a package including compiler.mk:
>
> Malformed conditional (defined(USE_GCC3) && empty(_PKGSRC_DEPS:Mgcc-3*))
>
> 5. line 248:
> Malformed conditional (${OPSYS} == "SunOS" && defined(_CC_IS_GCC))
> line 248: Missing dependency operator
packages Makefiles should not (and do not) include compiler.mk
directly, nor should USE_GCCn be defined. check the comments at the
top of compiler.mk.
hope this helps.
grant.