--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Johnny C. Lam wrote:

> Does the attached patch?  I'm unable to test this myself since my
> pkgsrc development machine is in transit.

No, quoting the whole "su" command line does not fix it.

Omitting the double quotes and using :Q in bsd.buildlink3.mk for
additions to MAKEFLAGS seems to do the trick.

  MAKEFLAGS+= _BLNK_ADD_TO.DEPENDS=${_BLNK_ADD_TO.DEPENDS:Q}

Doing the same to all lines with assignments to MAKEFLAGS appears to be
the correct way to do this.

I'm still not sure the leading space character (caused by an empty
_BLNK_ADD_TO.DEPENDS (line 109) and then adding to it (line 126,
disguised as ${_BLNK_DEPMETHOD.${_pkg_}})

  _BLNK_ADD_TO.DEPENDS= pth>=2.0.0:../../devel/pth
                      ^^^ 
is harmless.

ciao
     Klaus


--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="blk3.diff"

Index: bsd.buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/buildlink3/bsd.buildlink3.mk,v
retrieving revision 1.59
diff -u -r1.59 bsd.buildlink3.mk
--- bsd.buildlink3.mk	25 Jan 2004 18:44:31 -0000	1.59
+++ bsd.buildlink3.mk	26 Jan 2004 00:41:10 -0000
@@ -136,9 +136,9 @@
 .      endfor
 .    endif
 .  endfor
-MAKEFLAGS+=	_BLNK_ADD_TO.DEPENDS="${_BLNK_ADD_TO.DEPENDS}"
-MAKEFLAGS+=	_BLNK_ADD_TO.BUILD_DEPENDS="${_BLNK_ADD_TO.BUILD_DEPENDS}"
-MAKEFLAGS+=	_BLNK_ADD_TO.RECOMMENDED="${_BLNK_ADD_TO.RECOMMENDED}"
+MAKEFLAGS+=	_BLNK_ADD_TO.DEPENDS=${_BLNK_ADD_TO.DEPENDS:Q}
+MAKEFLAGS+=	_BLNK_ADD_TO.BUILD_DEPENDS=${_BLNK_ADD_TO.BUILD_DEPENDS:Q}
+MAKEFLAGS+=	_BLNK_ADD_TO.RECOMMENDED=${_BLNK_ADD_TO.RECOMMENDED:Q}
 .endif
 .for _depmethod_ in DEPENDS BUILD_DEPENDS RECOMMENDED
 .  if !empty(_BLNK_ADD_TO.${_depmethod_})
@@ -234,7 +234,7 @@
 .      endif
 .    endfor
 .    if empty(_BLNK_PKG_DBDIR.${_pkg_}:Mnot_found)
-MAKEFLAGS+=	_BLNK_PKG_DBDIR.${_pkg_}=${_BLNK_PKG_DBDIR.${_pkg_}}
+MAKEFLAGS+=	_BLNK_PKG_DBDIR.${_pkg_}=${_BLNK_PKG_DBDIR.${_pkg_}:Q}
 .    endif
 .  endif
 
@@ -265,7 +265,7 @@
 .      endif
 .    endif
 .    if empty(BUILDLINK_PREFIX.${_pkg_}:Mnot_found)
-MAKEFLAGS+=	BUILDLINK_PREFIX.${_pkg_}=${BUILDLINK_PREFIX.${_pkg_}}
+MAKEFLAGS+=	BUILDLINK_PREFIX.${_pkg_}=${BUILDLINK_PREFIX.${_pkg_}:Q}
 .    endif
 .  endif
 
@@ -698,7 +698,7 @@
 		else							\
 			${ECHO} ${WRKDIR};				\
 		fi
-MAKEFLAGS+=	_BLNK_WRKDIR="${_BLNK_WRKDIR}"
+MAKEFLAGS+=	_BLNK_WRKDIR=${_BLNK_WRKDIR:Q}
 .endif
 
 _BLNK_MANGLE_DIRS=	# empty

--ZGiS0Q5IWpPtfppv--