tech-pkg: Re: unnecessary definitions of PKG_TOOLS

Subject: Re: unnecessary definitions of PKG_TOOLS_BIN in defs.*.mk
To: Klaus Heinz <k.heinz.maer.vier@onlinehome.de>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 03/26/2004 17:23:59

On Sat, 27 Mar 2004, Klaus Heinz wrote:

> defs.Linux,mk:
>
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/sbin
>   ...
>   .if exists(${LOCALBASE}/sbin/pkg_info)
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/sbin
>   .endif
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/bin
>
> defs.Darwin.mk:
>
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/sbin
>   ...
>   .if exists(${LOCALBASE}/sbin/pkg_info)
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/sbin
>   .endif
>   PKG_TOOLS_BIN?=         ${LOCALBASE}/bin
>
> The first line above in defs.Linux.mk and defs.Darwin.mk could go.
> Or am I missing something?

The line
 PKG_TOOLS_BIN?=         ${LOCALBASE}/sbin
is correct. (sbin is correct not bin)

But you are right that there is unnecessary lines.

The .if .. .endif should be removed and the next line removed too. (Keep
one line to assign as ${LOCALBASE}/sbin.

   Jeremy C. Reed
   http://www.reedmedia.net/