Subject: Re: how to clean after every DEPENDS?
To: None <tech-pkg@NetBSD.org>
From: Alan Barrett <apb@cequrux.com>
List: tech-pkg
Date: 04/02/2004 09:55:25
On Fri, 02 Apr 2004, Alan Barrett wrote:
> OK, bsd.pkg.mk often uses ${DEPENDS_TARGET} where it should be using
> ${DEPENDS_TARGET:Q}. Try the appended patch.
Try it again, with the patch this time.
--apb (Alan Barrett)
Index: bsd.pkg.mk
--- bsd.pkg.mk 31 Mar 2004 11:19:09 -0000 1.1434
+++ bsd.pkg.mk 2 Apr 2004 07:42:14 -0000
@@ -3216,7 +3216,7 @@
@${TOUCH} ${INTERACTIVE_COOKIE}
@${FALSE}
.else
- ${_PKG_SILENT}${_PKG_DEBUG}cd ${.CURDIR} && ${MAKE} ${MAKEFLAGS} real-extract DEPENDS_TARGET=${DEPENDS_TARGET} PKG_PHASE=extract
+ ${_PKG_SILENT}${_PKG_DEBUG}cd ${.CURDIR} && ${MAKE} ${MAKEFLAGS} real-extract DEPENDS_TARGET=${DEPENDS_TARGET:Q} PKG_PHASE=extract
.endif
${PATCH_COOKIE}:
@@ -3415,7 +3415,7 @@
.if !target(reinstall)
reinstall:
${_PKG_SILENT}${_PKG_DEBUG}${RM} -f ${INSTALL_COOKIE} ${PACKAGE_COOKIE} ${PLIST}
- ${_PKG_SILENT}${_PKG_DEBUG}DEPENDS_TARGET=${DEPENDS_TARGET} ${MAKE} ${MAKEFLAGS} install
+ ${_PKG_SILENT}${_PKG_DEBUG}DEPENDS_TARGET=${DEPENDS_TARGET:Q} ${MAKE} ${MAKEFLAGS} install
.endif
# Deinstall
@@ -3508,7 +3508,7 @@
.endif
${_PKG_SILENT}${_PKG_DEBUG} \
${MAKE} ${MAKEFLAGS} ${UPDATE_TARGET} KEEP_WRKDIR=YES \
- DEPENDS_TARGET=${DEPENDS_TARGET}
+ DEPENDS_TARGET=${DEPENDS_TARGET:Q}
${_PKG_SILENT}${_PKG_DEBUG} \
[ ! -s ${DDIR} ] || for dep in `${CAT} ${DDIR}` ; do \
(if cd ../.. && cd "$${dep}" ; then \
@@ -3519,7 +3519,7 @@
${MAKE} ${MAKEFLAGS} deinstall; \
fi && \
${MAKE} ${MAKEFLAGS} ${UPDATE_TARGET} \
- DEPENDS_TARGET=${DEPENDS_TARGET} ; \
+ DEPENDS_TARGET=${DEPENDS_TARGET:Q} ; \
else \
${ECHO_MSG} "${_PKGSRC_IN}> Skipping removed directory $${dep}"; \
fi) ; \
@@ -4038,7 +4038,7 @@
${SHCOMMENT} Cycle through some FTP server here ;\
${ECHO_MSG} "Installing from source" ; \
${MAKE} ${MAKEFLAGS} package \
- DEPENDS_TARGET=${DEPENDS_TARGET} && \
+ DEPENDS_TARGET=${DEPENDS_TARGET:Q} && \
${MAKE} ${MAKEFLAGS} clean ; \
fi ; \
fi
@@ -4185,7 +4185,7 @@
${ECHO_MSG} "${_PKGSRC_IN}> Required installed package $$pkg: $${found} found"; \
else \
${ECHO_MSG} "${_PKGSRC_IN}> Required package $$pkg: NOT found"; \
- target=${DEPENDS_TARGET}; \
+ target=${DEPENDS_TARGET:Q}; \
${ECHO_MSG} "${_PKGSRC_IN}> Verifying $$target for $$dir"; \
if [ ! -d $$dir ]; then \
${ECHO_MSG} "=> No directory for $$dir. Skipping.."; \