On Saturday 05 June 2004 20:28, Juan RP wrote:
> On Sat, 5 Jun 2004 20:19:57 +0200
>
> "Julio M. Merino Vidal" <jmmv@menta.net> wrote:
> > On Saturday 05 June 2004 19:26, Juan Romero Pardines wrote:
> > > Module Name:	pkgsrc
> > > Committed By:	xtraeme
> > > Date:		Sat Jun  5 17:26:56 UTC 2004
> > >
> > > Modified Files:
> > > 	pkgsrc/emulators/openmsx: Makefile PLIST
> > >
> > > Log Message:
> > > Install a simple script into ${PREFIX}/bin to run openmsx.
> >
> > - No revision bump?
> > - Use SH instead of /bin/sh.
>
> True.
>
> > - Use ECHO instead of ECHO_MSG.
>
> I don't see any difference bettween them, yes I know, ECHO is shorter...

grep ECHO_MSG mk/bsd.pkg.mk

ECHO_MSG is used to output "internal" messages, and may be set to something
else different than echo (like 'true', to avoid messages).  ECHO is for
general use and will always be available.

> > - Create the script in post-build and install it in post-install.  These
> > are two different things conceptually, so each one belongs in a different
> > stage.
>
> Why is that?

Is build the same as install?  No.  So build first, then install, in different
stages.

Building things in post-install means that they get regenerated during every
'make install'.  This is not what you want.

And, building things during install means they get built with root privileges,
which could make a posterior 'make clean' fail.

> > - Why group commands?  Just do two separate echo's, one with > and
> >   the second with >>.  I.e., no (), nor \'s.
>
> And why not? :)

Unnecessary complexity.  And, IMHO, looks uglier ;)

Thanks!

-- 
Julio M. Merino Vidal <jmmv@menta.net>
The NetBSD Project - http://www.NetBSD.org/