Subject: Re: CVS commit: pkgsrc/multimedia/gmplayer
To: grant beattie <grant@NetBSD.org>
From: David Brownlee <abs@netbsd.org>
List: tech-pkg
Date: 06/21/2004 10:45:43
On Mon, 21 Jun 2004, grant beattie wrote:
> [moved to tech-pkg]
>
> On Mon, Jun 21, 2004 at 09:26:04AM +0200, Matthias Scheler wrote:
>
>>> no, it doesn't, but they should all be in one place, which is the
>>> reason why the change was made.
>>
>> The initial change should never have made because it opened the door for
>> future maintenance problems. The incomplete contents of
>> "pkgsrc/multimedia/mplayer-share/distinfo" caused by the recent change
>> demonstrated that nicely.
>
> I strongly disagree, Matthias. that was caused by committer error.
> "cvs diff", something we should all be doing before committing, would
> have picked this up. yes, I know we don't all do it all the time, but
> that is another issue, and mistakes do happen :-)
Suggestion: Add an 'mdi' & similar target ot mplayer which warns
it needs to be run in gmplayer.
--
David/absolute -- www.netbsd.org: No hype required --