--lIrNkN/7tmsD/ALM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 23, 2004 at 11:29:07AM -0700, Jeremy C. Reed wrote:

> I mentioned this before: USE_GNU_TOOLS+=3Dlex is broken under Linux

I'm not sure I'd use such strong wording - I've been using pkgsrc on
Linux for quite some time and I have flex(1) in the base system which
works with tools.mk just fine. I'm not saying it could not use
improvement, however :-)

> mk/tools.mk has:
>=20
> _TOOLS_OPSYS_HAS_GNU.lex+=3D      FreeBSD-*-* Interix-*-* Linux-*-* NetBS=
D-*-*
>=20
> It would be better to check for a flex/lex instead of blindly assuming
> Linux has it.

agreed.

> Can I fix this?
>=20
> While I am at it, may I remove Linux-*-* from _TOOLS_OPSYS_HAS_GNU.yacc
> and _TOOLS_OPSYS_HAS_GNU.patch too?
>=20
> Or maybe the tools.mk should abort if really not there but is expected?

I'd rather see a test if ${LEX}, ${PATCH}, etc. point to files that
exist, and if not, then pull in the pkgsrc version to avoid
unnecessarily pulling in the pkgsrc version (most Linux distributions do
include these GNU tools, but they are not mandatory to install, so
this should address it for more than a single case).

grant.


--lIrNkN/7tmsD/ALM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFBAb8mluYOb9yiFXoRAuYWAJ4/htVAMjV8WE8s8ygqdaB7L5c1uACcC3hO
KT63CyPJ7o/YUALbLTTSIfQ=
=dCPG
-----END PGP SIGNATURE-----

--lIrNkN/7tmsD/ALM--