Subject: Re: CVS commit: pkgsrc/graphics/blender
To: Reinoud Zandijk <reinoud@netbsd.org>
From: Jan Schaumann <jschauma@netmeister.org>
List: tech-pkg
Date: 02/26/2005 15:58:14
--HkMjoL2LAeBLhbFV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Reinoud Zandijk <reinoud@netbsd.org> wrote:
>=20
> Module Name:	pkgsrc
> Committed By:	reinoud
> Date:		Sat Feb 26 20:34:43 UTC 2005
>=20
> Modified Files:
> 	pkgsrc/graphics/blender: Makefile distinfo
> Added Files:
> 	pkgsrc/graphics/blender/patches: patch-ac patch-ad patch-ae patch-af
> 	    patch-ag
> Removed Files:
> 	pkgsrc/graphics/blender/patches: patch-aa
>=20
> Log Message:
> Big bugfix release fixing at least a 200 outstanding bugs and its
> game-engine is finally working now.

Great to see the update - thanks a lot!

There are some questions I have, though:

(1) Makefile

${AWK} '{print} NR =3D=3D 54 {print "env.Append(LINKFLAGS =3D \"-Wl,-R${X11=
BASE}/lib,-R${LOCALBASE}/lib\")"}'

This should probably use COMPILER_RPATH_FLAG instead of -Wl,-R...,-R
(and probably two instances for compilers that can only do one per
flag).

(2) Makefile

=2Eif 0
=2Eif defined(BLENDER_USE_OGG)


Why "if 0" ?

(3) patch-ad

+    OPENGL_HEADERS =3D /usr/X11R6/include

Is this correct?  Shouldn't this use X11PREFIX or X11BASE, or even
whatever the Mesa package uses via buildlink magic?

Also, does this file (source/nan_compile.mk) do the right thing on other
platforms?

I know this is a pain, which is why I hadn't updated the package in a
long time, so thanks for your efforts!

-Jan

--=20
You can blame it all on the Internet.
	Larry Wall

--HkMjoL2LAeBLhbFV
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFCIOLmfFtkr68iakwRAuYGAJ4yy63BTzxtx5uJj6dn6g4ZMtJHSQCeJtsn
9VU/oyrUS14iSeRcb21zqBk=
=8Wc1
-----END PGP SIGNATURE-----

--HkMjoL2LAeBLhbFV--