Subject: Re: CVS commit: pkgsrc/graphics/blender
To: None <tech-pkg@NetBSD.org>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: tech-pkg
Date: 02/26/2005 22:52:28
--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 26, 2005 at 03:58:14PM -0500, Jan Schaumann wrote:
> (1) Makefile
> 
> ${AWK} '{print} NR == 54 {print "env.Append(LINKFLAGS = \"-Wl,-R${X11BASE}/lib,-R${LOCALBASE}/lib\")"}'
> 
> This should probably use COMPILER_RPATH_FLAG instead of -Wl,-R...,-R
> (and probably two instances for compilers that can only do one per
> flag).

Oef... i dont know this COMPILER_RPATH_FLAG, i think someone with a bit 
more knowledge of the pkgsrc system ought to look at this.

> (2) Makefile
> 
> .if 0
> .if defined(BLENDER_USE_OGG)
> 
> 
> Why "if 0" ?

:-) well that were options that were once selectable but not implemented 
now since we don't use configure anymore i dont know how to implement these 
choices.

> (3) patch-ad
> 
> +    OPENGL_HEADERS = /usr/X11R6/include

Oeps, forgot to remove this old patch. Since `make' is not used anymore 
this patch patches a file that is not used. I've removed it.

> Also, does this file (source/nan_compile.mk) do the right thing on other
> platforms?

This is not used anymore; all is done trough Scons now ... (!) allthough i 
would love to test it on a non-NetBSD pkgsrc.

> I know this is a pain, which is why I hadn't updated the package in a
> long time, so thanks for your efforts!

You're welcome :)
Reinoud

--azLHFNyN32YCQGCU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQiDvlYKcNwBDyKpoAQIzVgf+OnFItLgwr+QX9WQdREi5J0JcxUnhHXLx
tB6pY0258zDHBVvhrLwL/ThlxK5zxR+5lwt57mZaTFJXK+EWCMHB0/rq5jkd5Cxc
FxLcF4LmI76PsLD3E/J035ptzMYHqy07zhGniNp/EE5xxR1EjippuRI7QrxxxGxN
jjIh9JuL624Ouv8UHnueG7+qiOmgMzXjLqRxaVOiOsF0Pk2PzdYL+HCth8SyIvGU
MrEUbIYFhnx15szddcBb+Athi/GmexqlpDovc3mpt4iIZjU3xTVFzadLJj0SFNjQ
4WUW5YIWe7EpqcVnZu1udsWvQd1mmGTb7YRJWhkNS+qb1n91m8QooA==
=Bn7s
-----END PGP SIGNATURE-----

--azLHFNyN32YCQGCU--