Subject: Re: broken Makefile for libdvdcss?
To: None <tech-pkg@NetBSD.org>
From: Alan Barrett <apb@cequrux.com>
List: tech-pkg
Date: 07/26/2005 19:45:33
On Tue, 26 Jul 2005, Jeremy C. Reed wrote:
> Index: multimedia/libdvdcss/Makefile
> +INTERACTIVE_STAGE=	fetch
> +
> +_FETCH_MESSAGE=  [...]

No, that will print the _FETCH_MESSAGE even of LIBDVDCSS_MASTER_SITES is
defined.  I think you want something more like the appended patch, which
conditionally sets BROKEN.

--apb (Alan Barrett)


Index: multimedia/libdvdcss/Makefile
===================================================================
--- Makefile	21 Jul 2005 01:35:50 -0000	1.8
+++ Makefile	26 Jul 2005 14:31:22 -0000
@@ -18,6 +18,12 @@
 
 RESTRICTED=	Legal problems due to CSS code
 
+.include "../../mk/bsd.prefs.mk"
+
+.if !defined(LIBDVDCSS_MASTER_SITES) || empty(LIBDVDCSS_MASTER_SITES)
+BROKEN=		LIBDVDCSS_MASTER_SITES must be defined (typically in /etc/mk.conf)
+.endif
+
 # no source because of the CSS source code in it
 NO_SRC_ON_FTP=		${RESTRICTED}
 NO_BIN_ON_FTP=		${RESTRICTED}