Subject: Re: CVS commit: pkgsrc/net/scamper
To: Todd Vierling <tv@duh.org>
From: Dieter Baron <dillo@danbala.tuwien.ac.at>
List: tech-pkg
Date: 11/02/2005 20:51:08
hi,

> > : Require IPv6 support via the options framework.
> >
> >   This is not the right fix.  The options framework is for options,
> > i. e. setting that a user can choose wether to enable.
> 
> Well, I did use _OPSYS_HAS_INET6 at first in the sipcalc package, but that
> seemed even clunkier because it is accessing _-prefixed variables (and does
> not change behavior if the user explicitly requested omission of IPv6
> support).  USE_INET6 is deprecated, too, in favor of the "inet6" option.

  If _OPSYS_HAS_INET6 is needed in packages, we should just make it
public by droping the _-prefix and documenting it.

> >   Do you really want this package to fail on an IPv6 capabale system
> > if the user choose to disable the inet6 option?
> 
> Ideally, yes.  If the user requested omission of IPv6 support on a global
> basis, packages that require IPv6 support should indeed fail.

  Hm, if that was your intention, then your solution seems correct.
I'm just uncomfortable with options that must be set.  What do others
think?

					yours,
					dillo