On Mon, Dec 05, 2005 at 08:01:05AM +0100, Bernd Ernesti wrote:
> On Sun, Dec 04, 2005 at 02:48:21AM +0100, joerg@britannica.bec.de wrote:
> > On Sun, Dec 04, 2005 at 02:23:53AM +0100, Bernd Ernesti wrote:
> > > > Log Message:
> > > > Just expect X11 libraries to provide Xv, since XFree86 and Xorg
> > > > have provided Xv for ages. Also add build dependency on pod2man.
> > > 
> > > revision 1.2
> > > date: 2002/08/14 02:14:16;  author: dmcmahill;  state: Exp;  lines: +6 -1
> > > make sure that ${X11BASE}/include/X11/extensions/Xvlib.h before trying
> > > to build this.  If not, bail out with a NOT_FOR_PLATFORM since Xv didn't
> > > appear until XF4.
> > > 
> > > Right now we are supporting XFree 3.x for 1.6 so this breaks it.
> > 
> > For 1.6, you can still use Xorg from pkgsrc. The check is broken for any
> > non-native X11 and personally I think a build error on 1.6 due to
> > missing feature is better than not compiling this with Xorg from pkgsrc.
> 
> Which build error?
> Does Xorg doesn't have this header? If so then there needs to be another
> check and not removing it.

We support both native and pkgsrc X11 installations in pkgsrc. The check
only works for native installations, since e.g. Xorg installed as
dependency would be installed *after* that check. So it is disabling a
completely valid combination.

This does NOT break XFree 3.x, it WAS broken before. It was just an
explicit PKG_FAIL, which like written above is bogus.

Joerg