Subject: WARNING: [subst.mk] Ignoring non-text file ... assembler?
To: None <tech-pkg@netbsd.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 10/04/2006 14:33:58
Working on updating wdm and saw:
=> Unwrapping files-to-be-installed.
WARNING: [subst.mk] Ignoring non-text file "./configs/wdm-config".
file says:
work.glacier/wdm-1.28/configs/wdm-config: Assembler source
This is file-4.16 on NetBSD 3.99.24. Also same with file-4.14 on DragonFly
1.7.0-DEVELOPMENT.
The file starts with:
! $XConsortium: xdm-conf.cpp /main/3 1996/01/15 15:17:26 gildea $
!
! wdm configuration file input (sed in Makefile)
!
DisplayManager.errorLogFile: /var/log/xdm-errors.log
DisplayManager.pidFile: /var/run/xdm-pid
DisplayManager.keyFile: /usr/pkg/etc/wdm/xdm-keys
DisplayManager.servers: /usr/pkg/etc/wdm/Xservers
DisplayManager.accessFile: /usr/pkg/etc/wdm/Xaccess
! All displays should use authorization, but we cannot be sure
My work-around is:
Index: mk/subst.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/subst.mk,v
retrieving revision 1.35
diff -u -r1.35 subst.mk
--- mk/subst.mk 2 Jul 2006 09:35:05 -0000 1.35
+++ mk/subst.mk 4 Oct 2006 19:29:35 -0000
@@ -39,7 +39,7 @@
_SUBST_IS_TEXT_FILE?= \
{ ${TEST} -f "$$file" \
&& ${FILE_CMD} "$$file" \
- | ${EGREP} "(executable .* script|shell script|text)"; \
+ | ${EGREP} "(executable .* script|shell script|text|Assembler source)"; \
} >/dev/null 2>&1
_SUBST_BACKUP_SUFFIX= .subst.sav
May I commit above?
I guess the real fix would be to improve file(1).
Then again why do we even have this _SUBST_IS_TEXT_FILE? If the pkgsrc
developer chooses to use the SUBST conversion, why not let them choose
the files they want and allow it?