--TB36FDmn/VVEgNH/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Roland Illig <rillig@NetBSD.org> wrote:

> >Does that look ok?  I haven't completed a bulk-build with this patch
> >yet, but I do have one running, and it hasn't bailed out yet. ;-)
> >
> >... ${FIND} . -type f -newer ... -name ./work -or ...
>=20
> You should write
>=20
>     find ! \( -name "work*" -or ... \)
>=20
> instead. The ''name'' is only the basename, so it won't ever include a=20
> slash. Also, on my machine, the working directory is called work.bacc,=20
> not work alone.

Yeah, I noticed that, too.  The current implementation doesn't pay
attention to whatever the user may have set the WRKDIR variable to.
This should probably be

${FIND} ... ! \( -name "${WRKDIR}" -or ... \)

> >nnewfiles=3D"`echo ${newfiles} | ${WC} -w`"
>=20
> You can easily support white-space in filenames by writing
>=20
>     nnewfiles=3D`${ECHO} "$$newfiles" | ${WC} -w`

wc(1) would still count any file within $$newfiles that contains a
whitespace as two separate words, no?

$ echo "foo bar" "baz" | wc -w
	3
$=20

> 2. I used $$newfiles instead of ${newfiles}, as you probably
>    meant the shell variable, not the make(1) variable.

Yes, thanks!

> >${FIND} ${PKG_DBDIR} -maxdepth 1 -type d ! -name '.' -print
>=20
> This won't work on IRIX and some other platforms:
>=20
> $ /usr/bin/find . -maxdepth 3
> -maxdepth: bad option
> Usage: find path-list predicate-list

Bah, stupid IRIX.

${FIND} ${PKG_DBDIR} -type d ! -name '.' -prune -print

?

-Jan

--=20
"I am so amazingly cool you could keep a side of meat in me for a=20
month. I am so hip I have difficulty seeing over my pelvis."

--TB36FDmn/VVEgNH/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (NetBSD)

iD8DBQFFYSqffFtkr68iakwRAjkGAJ96IE3bWU0AKnxkrMJD7xh2K/fMXACeNYNl
H/gXr55CioTn//7vg2eB0PU=
=RAUK
-----END PGP SIGNATURE-----

--TB36FDmn/VVEgNH/--