Subject: Tiny change to fetch.mk
To: None <tech-pkg@netbsd.org>
From: Amitai Schlair <schmonz@schmonz.com>
List: tech-pkg
Date: 12/22/2006 19:23:38
The following one-line change silences some longstanding noise in
mail/qmail, caused by the fact that its ${DISTFILES} is also a common
${PATCHFILES}, resulting in the file being listed twice in $
{_ALLFILES}. What the noise looks like (similar for other targets,
pkg_chk, etc.):
$ cd pkgsrc/mail/qmail
$ make clean
make: "/home/build/trees/pkgsrc-current/mk/fetch/fetch.mk" line 133:
warning: duplicate script for target "/home/build/trees/pkgsrc-
current/distfiles/netqmail-1.05.tar.gz" ignored
make: "/home/build/trees/pkgsrc-current/mk/fetch/fetch.mk" line 133:
warning: using previous script for "/home/build/trees/pkgsrc-current/
distfiles/netqmail-1.05.tar.gz" defined here
===> Cleaning for qmail-1.03nb11
$
Do people agree that this safe to commit?
- Amitai
Index: mk/fetch/fetch.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/fetch/fetch.mk,v
retrieving revision 1.23
diff -u -r1.23 fetch.mk
--- mk/fetch/fetch.mk 25 Nov 2006 21:33:39 -0000 1.23
+++ mk/fetch/fetch.mk 23 Dec 2006 00:14:03 -0000
@@ -26,6 +26,7 @@
_PATCHFILES?= ${PATCHFILES}
.endif
_ALLFILES?= ${_DISTFILES} ${_PATCHFILES}
+_ALLFILES:= ${_ALLFILES:O:u} # remove duplicates
_BUILD_DEFS+= _DISTFILES _PATCHFILES