Subject: Re: audio/libvisual Solaris10
To: None <tech-pkg@NetBSD.org, joerg@britannica.bec.de>
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
List: tech-pkg
Date: 02/19/2007 11:35:20
> X-Virus-Scanned: amavisd-new at enst.fr
> X-Original-To: tech-pkg@netbsd.org
> Delivered-To: tech-pkg@netbsd.org
> Date: Mon, 19 Feb 2007 10:42:40 +0100
> From: Joerg Sonnenberger <joerg@britannica.bec.de>
> To: tech-pkg@NetBSD.org
> Subject: Re: audio/libvisual Solaris10
> Mail-Followup-To: tech-pkg@netbsd.org
> Content-Disposition: inline
> User-Agent: Mutt/1.5.13 (2006-08-11)
> 
> On Mon, Feb 19, 2007 at 10:38:57AM +0100, Gilles Dauphin wrote:
> > --------------------------------------------
> > --- libvisual/lv_types.h.orig   Mon Feb 13 21:54:08 2006
> > +++ libvisual/lv_types.h        Mon Feb 19 10:29:32 2007
> > @@ -38,7 +38,7 @@
> >  
> >  #define VISUAL_TABLESIZE(table)                        (sizeof (table) / 
sizeof (table[0]))
> >  
> > -#if !defined(VISUAL_OS_WIN32)
> > +#if !defined(VISUAL_OS_WIN32) && !defined(_SYS_INT_TYPES_H)
> >  #ifndef uint8_t
> >  #define uint8_t                u_int8_t
> >  #endif
> 
> This looks stupid in general, why not just include inttypes.h and expect
> the compiler/RTL to provide it ?!

because on solaris 'uint8_t' is a 'typedef' and '#ifndef uint8_t' is true.
Others systems would '#define uint8_t'. I don't have enought time to patch 
libvisual configure's.
I aggree , this look stupid :(

Gilles
> 
> Joerg