Subject: Re: change to check/check-shlibs.mk breaks library path checks
To: None <tech-pkg@netbsd.org>
From: Klaus Heinz <k.heinz.apr.sieben@kh-22.de>
List: tech-pkg
Date: 04/30/2007 15:19:19
--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

 [ checking of shared library search paths is broken for installation
   into DESTDIR ]

Instead of (probably bogus) warnings about missing shared libraries and
stopping the installation the appended patch disables checking of shared
libraries for the case that a DESTDIR installation takes place.

Ok to commit?

ciao
     Klaus

--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="check-shlibs.mk.diff"

Index: check-shlibs.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/check/check-shlibs.mk,v
retrieving revision 1.11
diff -u -r1.11 check-shlibs.mk
--- check-shlibs.mk	14 Apr 2007 14:17:49 -0000	1.11
+++ check-shlibs.mk	30 Apr 2007 13:10:56 -0000
@@ -23,7 +23,10 @@
 _PKG_VARS.check-shlibs=		CHECK_SHLIBS_SUPPORTED
 
 .if defined(PKG_DEVELOPER)
+. if ${_USE_DESTDIR} == "no"
+# At the moment, CHECK_SHLIBS only works for non-DESTDIR installation
 CHECK_SHLIBS?=			yes
+. endif
 .endif
 CHECK_SHLIBS?=			no
 CHECK_SHLIBS_SUPPORTED?=	yes

--VS++wcV0S1rZb1Fb--