Joerg Sonnenberger wrote:

> On Tue, May 22, 2007 at 06:40:26PM -0500, Amitai Schlair wrote:
>> Building a "Universal" (fat) binary on Mac OS X requires passing some 
>> extra arguments to the compiler and linker. Apple recommends setting 
>> them as CFLAGS and LDFLAGS, and this does the trick for software which 
>> respects those variables.
> 
> I would actually *not* follow that recomendation and put it in CC/LD.

Will that actually work? For a different application, Thor tried to pass 
some flags through CC and LD in pkgsrc and it broke the wrappers. There 
are no wrappers at bootstrap time, of course, but devel/bmake should be 
able to build as Universal later, too.

>> The following diff makes devel/bmake respect CFLAGS passed in the 
>> environment, which lets me build and run a Universal binary of bmake. Is 
>> this OK to commit?
> 
> Can you just use += all the time? That should be enough.

It turns out not to be, so I committed the diff as it was.