New "renderproto" broken (was: CVS commit: pkgsrc/x11)

[Matthias Scheler <tron%NetBSD.org@localhost>]

On Wed, Jan 16, 2008 at 11:52:36PM +0100, Tobias Nygren wrote:
> > In file included from 
> > /Users/tron/obj/chat/xchat/work.excalibur/.buildlink/include/X11/extensions/Xrender.h:29,
> >                  from 
> > /Users/tron/obj/chat/xchat/work.excalibur/.buildlink/include/X11/Xft/Xft.h:44,
> >                  from xtext.h:6,
> >                  from fe-gtk.c:48:
> > /Users/tron/obj/chat/xchat/work.excalibur/.buildlink/include/X11/extensions/render.h:29:
> >  error: parse error before 'Glyph'
> > /Users/tron/obj/chat/xchat/work.excalibur/.buildlink/include/X11/extensions/render.h:29:
> >  warning: type defaults to 'int' in declaration of 'Glyph'
> 
> 
> Looks like the same problem that was hitting modular-xorg-server.
> (render.h now assumes that X.h has been included in advance)
> 
> I'm not sure if it's the applications ...

It's not the application, it is "Xft.h" in this case. The XChat include
file looks like this:

#ifdef USE_XFT
#include <X11/Xft/Xft.h>
#endif

And "Xft.h" uses these includes:

#include <stdarg.h>
#include <ft2build.h>
#include FT_FREETYPE_H
#include <fontconfig/fontconfig.h>
#include <X11/extensions/Xrender.h>

> ... or renderproto that need to be fixed.

I would argue that "renderproto" is broken and that fixing it in
"renderproto" will require one patch instead of hundreds.

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/