pkgtools/pbulk-base build error in Linux

[Silas Silva <silasdb%gmail.com@localhost>]

Hi all,

I just made a chroot environment with debootstrap command in Ubuntu
9.04. I successfully bootstrapped pkgsrc-2009Q2 and started to build
pkgtools/pbulk, when I got the following error (in dependency
pkgtools/pbulk-base):

    ===> Building for pbulk-base-0.38
    gcc -Wno-error -Wno-error  -Wall -Wstrict-prototypes -Wmissing-prototypes 
-Wpointer-arith -Wno-uninitialized -Wreturn-type -Wcast-qual -Wpointer-arith 
-Wwrite-strings -Wswitch -Wshadow -Werror  -D_GNU_SOURCE -DHAVE_NBCOMPAT_H=1 
-I/usr/pkgsrc/pkgtools/pbulk-base/work/libnbcompat -c read_child.c
    cc1: warnings being treated as errors
    read_child.c: In function 'read_from_child':
    read_child.c:73: error: format not a string literal and no format arguments
    *** Error code 1

See that in this environment (not everywhere?) the -Werror flag is
passed (is it the flag that makes the compiler handle warnings as
errors?), so I had to apply the attached patch to make it work.

Is this patch applicable?

Thank you very much.

-- 
Silas Silva

--- read_child.c.orig   2009-07-28 15:59:47.000000000 -0300
+++ read_child.c        2009-07-28 16:00:19.000000000 -0300
@@ -70,7 +70,7 @@ read_from_child(const char *dir, const c
                (void)close(fd);
                (void)kill(child, SIGTERM);
                (void)waitpid(child, &status, 0);
-               err(1, error);
+               err(1, "%s", error);
        }
 
        (void)close(fd);