Re: SunOS with no audio installed

[David Brownlee <abs%netbsd.org@localhost>]

2009/11/22 Filip Hajny <filip%joyent.com@localhost>:
> On 22.11.2009, at 11:12, OBATA Akio wrote:
>
>>> As explained above, sndfile_play is not Solaris-specific, and only
>>> includes audioio.h on Solaris platforms.
>>
>> Yes, it should be failed to compile sndfile_play.c and failed to "make
>> build",
>> instead of succeed to build with missing sndfile_play.
>> Even if audlo-support-less platforms, sndfile_play will be built
>> (and it just say "not support" every execution).
>>
>
> Yeah, the problem is that the software's configure senses the include file
> not being there, and simply doesn't include the dependent binary/lib in the
> resulting Makefile. So everything's 'graceful' from the original developer's
> point of view. We can either keep their logic in place and replicate it in
> PLIST, or we can patch their Sun audio logic away and replace with a user
> settable preference. What's the more pkgsrc-ish approach?

The ideal situation would be to build with the full functionality in
all cases, but that is difficult in this case as it would involve
providing a sun include file.

I would probably go with an 'audioplay' feature, which is on for non
Solaris platforms, otherwise set appropriately based on include file
detection.

It is annoying that the 'same' binary package built on two separate
Solaris boxes could have different functionality, but I don't see an
easy way around that.