tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: patch: handling python distutils and egg files



Thomas Klausner <wiz%NetBSD.org@localhost> writes:

> On Sat, Jul 24, 2010 at 08:00:28AM -0400, Greg Troxel wrote:
>> >> diff -u -p -r1.4 PLIST
>> >> --- security/py-crypto/PLIST      23 Jul 2010 23:24:19 -0000      1.4
>> >> +++ security/py-crypto/PLIST      24 Jul 2010 01:39:23 -0000
>> >> @@ -265,4 +265,4 @@ ${PYSITELIB}/Crypto/__init__.pyo
>> >>  ${PYSITELIB}/Crypto/pct_warnings.py
>> >>  ${PYSITELIB}/Crypto/pct_warnings.pyc
>> >>  ${PYSITELIB}/Crypto/pct_warnings.pyo
>> >> -${PYSITELIB}/${EGG_FILE}
>> >> +${EGG_MAYBE}${PYSITELIB}/${EGG_FILE}
>> >
>> > IIUC, this is not needed?
>> 
>> It is necessary because when built under Python 2.4 the egg file will
>> not be created, but under 2.5+ it will be.
>
> Sorry for not asking more verbosely, but what I meant was that you have
> PRINT_PLIST_AWK+=      
> {gsub("${PYSITELIB}/${EGG_NAME}-py${PYVERSSUFFIX}.egg-info", 
> "$${EGG_MAYBE}$${PYSITELIB}/$${EGG_FILE}") }
> and I'm wondering if that that doesn't mean that
> ${PYSITELIB}/${EGG_FILE}
> in the PLIST should automatically commented out, and we don't need to
> change PLISTs?

I think the only PYDISTUTILSPKG packages that have eggs in PLIST are
ones I have just changed.

I realize your goal, but I don't follow your proposed mechanism.  I
think that a distutils-using PLIST needs to contain:

  ${PLIST.eggfile}${PYSITELIB}/${EGG_FILE}

to have the egg file for 2.5+ and not for 2.4.  My awk pattern was
intended to generate that.  Can you say what line should be in the
PLIST?

I've committed this, so you can run it.

Attachment: pgp9FfKp2yhgW.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index