tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

gmake + USE_FEATURES=nbcompat = failure



Hello. If package uses non-bmake tool for build, e.g. GNU make
and has USE_FEATURES=nbcompat in Makefile, build fails
like this

   config.status: creating Makefile
   config.status: creating nbcompat/config.h
   Makefile:67: *** missing separator.  Stop.
   *** Error code 2

How to reproduce: add 
   USE_FEATURES+=nbcompat
to x11/mrxvt/Makefile and try to build it.

I'd like to commit the following patch fixing this issue.
Objections?

Index: inplace.mk
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/libnbcompat/inplace.mk,v
retrieving revision 1.9
diff -u -r1.9 inplace.mk
--- inplace.mk  17 Aug 2009 18:43:49 -0000      1.9
+++ inplace.mk  19 Aug 2011 11:19:00 -0000
@@ -47,7 +47,7 @@
                CPPFLAGS=${CPPFLAGS:M*:Q}                               \
                ${CONFIGURE_ENV:NLIBS=*} ${CONFIG_SHELL}                \
                ${CONFIGURE_SCRIPT} ${NBCOMPAT_CONFIGURE_ARGS} &&       \
-               ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM}
+               ${SETENV} ${MAKE_ENV} ${MAKE}
 .if !empty(LIBNBCOMPAT_USE_PIC:M[Yy][Ee][Ss])
        @${STEP_MSG} "Configuring and building libnbcompat (PIC version)"
        ${RUN} ${_ULIMIT_CMD}                                           \
@@ -55,5 +55,5 @@
                ${CONFIGURE_ENV:NLIBS=*} CFLAGS=${CFLAGS:Q}" -fPIC"     \
                ${CONFIG_SHELL}                                         \
                ${CONFIGURE_SCRIPT} ${NBCOMPAT_CONFIGURE_ARGS} &&       \
-               ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM}
+               ${SETENV} ${MAKE_ENV} ${MAKE}
 .endif


Home | Main Index | Thread Index | Old Index