tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PHP_VERSIONS_ACCEPTABLE



phpversion.mk says that most php5 modules also work fine on php-5.3
provided by pkgsrc.  "Most"! but not all. php4 was removed from pkgsrc
years ago, PHP_VERSIONS_ACCEPTED now defaults to "5 5.3".
I think PHP_VERSIONS_ACCEPTED+= logic is not necessary anymore.

I'd like to commit the following. Objections?

Index: lang/php/phpversion.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/php/phpversion.mk,v
retrieving revision 1.15
diff -u -r1.15 phpversion.mk
--- lang/php/phpversion.mk      14 Sep 2011 16:44:26 -0000      1.15
+++ lang/php/phpversion.mk      19 Oct 2011 21:05:17 -0000
@@ -78,19 +71,6 @@
 _PHP_VERSION_${pv}_OK= yes
 .endfor
 
-# most pkgsrc PHP5 extensions work on both PHP 5.2.* and 5.3.*; if marked
-# as '5', accent any 5.*
-.if defined(_PHP_VERSION_5_OK)
-.  if !defined(_PHP_VERSION_53_OK)
-_PHP_VERSION_53_OK=    yes
-PHP_VERSIONS_ACCEPTED+= 53
-.  endif
-.  if !defined(_PHP_VERSION_52_OK)
-_PHP_VERSION_52_OK=    yes
-PHP_VERSIONS_ACCEPTED+= 52
-.  endif
-.endif
-
 # check what is installed
 .if exists(${LOCALBASE}/lib/php/20040412)
 _PHP_VERSION_5_INSTALLED=      yes
Index: textproc/php-intl/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/php-intl/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- textproc/php-intl/Makefile  10 Jun 2011 09:40:01 -0000      1.6
+++ textproc/php-intl/Makefile  19 Oct 2011 21:07:17 -0000
@@ -6,8 +6,6 @@
 CATEGORIES+=           textproc
 COMMENT=               PHP extension for i18n
 
-PHP_VERSIONS_ACCEPTED= 5
-
 PKG_DESTDIR_SUPPORT=   user-destdir
 
 CONFIGURE_ARGS+=       --enable-${MODNAME}=shared,${BUILDLINK_DIR}


Home | Main Index | Thread Index | Old Index