Re: CVS commit: pkgsrc/security/openssl

["OBATA Akio" <obache%netbsd.org@localhost>]

Probably, buildlink3.mk also should be changed, and maybe PKGREVISION should be 
bumped.

See builtin.mk.
If USE_FEATURES.openssl contains "threads" and builtin openssl does not have 
threads support,
builtin one will not be used.

Some package require thread supported OpenSSL, so if "threads" option is 
disabled and
USE_FEATURES.openssl=threads is defined, PKG_FAIL_REASON must be risen.

There are no changes of binary packages about contents (installed files),
but one change for binary package, PKG_OPTIONS=threads is defined or not.

Currently,  there are no way to detect DISABLED option from binary package,
so no way to detect whether installed openssl is built before "threads" option 
is introduced
or after it but disabled.

How to resolve this issue?
I've handed same issue in graphics/imlib2/buildlink3.mk, at introduced x11 
option to disable X11 support.
At the case, I bumped PKGREVISION, and let to detect whether installed PKG 
version is older than
x11 option was introduced, then check PKG_BUILD_OPTIONS seconded.
Much smart way is welcomed!

On Thu, 03 Nov 2011 07:51:07 +0900, John Nemeth <jnemeth%netbsd.org@localhost> 
wrote:

> Module Name:    pkgsrc
> Committed By:   jnemeth
> Date:           Wed Nov  2 22:51:07 UTC 2011
>
> Modified Files:
>         pkgsrc/security/openssl: Makefile options.mk
>
> Log Message:
> Add a new threads option which is on by default.  The purpose of this is
> to allow other packages that can't handle threads to link against this.
>
> No revbump since there is no change to binary packages.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.157 -r1.158 pkgsrc/security/openssl/Makefile
> cvs rdiff -u -r1.6 -r1.7 pkgsrc/security/openssl/options.mk
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


--
OBATA Akio / obache%NetBSD.org@localhost