Re: pkg_tarup inclusion in pkg_create

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Jan 03, 2012 at 12:22:35PM +0000, David Brownlee wrote:
> On 3 January 2012 02:46, Joerg Sonnenberger 
> <joerg%britannica.bec.de@localhost> wrote:
> > On Tue, Jan 03, 2012 at 03:30:54AM +0100, Julian Fagir wrote:
> >> in the pkg_tarup comments you can read somebody proposing the integration 
> >> of
> >> pkg_tarup to pkg_admin. pkg_admin is not suited for that, but pkg_create 
> >> is,
> >> as it is the tool behind pkg_tarup.
> >> I'm not much into the whole packaging thing, but I need this 
> >> functionality, so
> >> I numbly took over all the functionality of pkg_tarup to pkg_admin.
> >
> > I am against this. pkg_tarup is essentially a hack for not keeping
> > binary packages around. The DESTDIR support removed most reasons for
> > doing modifications to the file system without safety belts and can also
> > make sure that such a binary package is always around. More importantly,
> > there are a number of cases where pkg_add $foo followed by pkg_tarup
> > will not create the same state.
> 
> Would it make more sense to regard it as more of a pkg_snapshot tool - to take
> a snapshot of the installed package state so it can be restored?

It is a snapshot, but it can't necessarily be used to restore the
package. My technical issue with the patch is that it re-introduces a
pkgdb dependency in pkg_create, when it those are only left for the sake
of non-destdir installations and should go away at some point. Frankly,
this is a special purpose hack and should just stay as shell script.

Joerg