Re: Depreciate PERL5_MODULE_TYPE=Module::Install

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Thu, Sep 06, 2012 at 09:16:56AM +0200, Jens Rehsack wrote:
> 2012/9/3 Thomas Klausner <wiz%netbsd.org@localhost>:
> > On Mon, Sep 03, 2012 at 01:33:20PM +0200, Jens Rehsack wrote:
> >> Module::Install is for module authors only and most CPAN authors
> >> who use it for their Perl-Module distributions are very familiar
> >> with it meanwhile (or let Dist::Zilla deal with M::I), so I
> >> decided to change all remaining pkgsrc packages building with
> >> PERL5_MODULE_TYPE=Module::Install using the distibution bundled
> >> M::I version.
> >
> > What does this change, effectively, for pkgsrc?

Can you please answer this question, too?

> > Should we remove the option from lang/perl5/module.mk?
> >  Thomas
> 
> Probably later. If you know as fast way to do it, you could mark the
> option as depreciated.

The attached diff should do it (untested).
 Thomas

Index: module.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/perl5/module.mk,v
retrieving revision 1.66
diff -u -r1.66 module.mk
--- module.mk   18 May 2012 21:04:46 -0000      1.66
+++ module.mk   6 Sep 2012 08:47:25 -0000
@@ -60,6 +60,7 @@
 .  endif
 .elif ${PERL5_MODULE_TYPE} == "Module::Install"
 PERL5_MODTYPE=         modinst
+WARNINGS+=      "[lang/perl5/module.mk] The package ${PKGNAME} is using the 
deprecated Module::Install method."
 .elif ${PERL5_MODULE_TYPE} == "Module::Install::Bundled"
 PERL5_MODTYPE=         modinst
 .elif ${PERL5_MODULE_TYPE} == "MakeMaker"