Re: (sysutils/dd_rescue) Re: broken packages for 2013q2

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Thu, Jun 13, 2013 at 04:57:49PM +0900, Makoto Fujiwara wrote:
> Index: sysutils/dd_rescue/patches/patch-ab
> ===================================================================
> RCS file: /cvs/cvsroot/pkgsrc/sysutils/dd_rescue/patches/patch-ab,v
> retrieving revision 1.6
> diff -u -r1.6 patch-ab
> --- sysutils/dd_rescue/patches/patch-ab       4 Jun 2013 00:47:46 -0000       
> 1.6
> +++ sysutils/dd_rescue/patches/patch-ab       13 Jun 2013 07:49:27 -0000
> @@ -1,11 +1,31 @@
>  $NetBSD: patch-ab,v 1.6 2013/06/04 00:47:46 mef Exp $
>  
> +(1) clang flags:
> +dd_rescue.c:1494:22: warning: implicit declaration of function 'basename' is 
> invalid in C99 [-Wimplicit-function-declaration]
> +        const char* ibase = basename(inm);

OK

> +(2)
>  See http://gnats.netbsd.org/38620
>  dd_rescue: (fatal): allocation of aligned buffer failed!
>  
> +(3) clang flags:
> +dd_recue.c:(.text+0x12b4): undefined reference to `mypread'
> +dd_rescue.c:(.text+0x1374): undefined reference to `mypwrite'

OK

> +
> +(4) clag flags:
> +dd_rescue.c:1495:31: warning: passing 'const char *' to parameter of type 
> 'char *' discards qualifiers [-Wincompatible-pointer-types]
> +        const char* ibase = basename(inm);

Leave this one out, it is a portability issue that shouldn't be ignored
like this.

With that change, commit it.

Joerg